core,discovery: add checks for PriceInfo.pixelsPerUnit==0 #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
requested changes
Mar 25, 2021
yondonfu
requested changes
Mar 25, 2021
|
Sorry , yes you're entirely correct.
Fixed in 1a7be84
|
kyriediculous
force-pushed
the
nv/nil-ppu
branch
from
1a7be84 to
84effcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Using
common.RatPrinceInfofor convertingnet.PrinceInfo->big.Ratand handling the error case.This function already does a check for the
PriceInfodenominator being 0Specific updates (required)
Didn't explicitly test the predicate function, would require us to move it to global scope I believe. Can always do this still.
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass